Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cause last element index check #122

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix: cause last element index check #122

merged 1 commit into from
Nov 4, 2023

Conversation

dmuharemagic
Copy link
Contributor

@dmuharemagic dmuharemagic commented Nov 3, 2023 •
edited
Loading

There was a bug introduced in one of the latest commits in PR #116, which replaces the lastElement !== -1 check with lastElement !== 1, consequently breaking the cause property extraction for a message with a single parameter.

Checklist

Uzlopak
Uzlopak approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsumners
jsumners approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jsumners jsumners merged commit 7ea98d1 into fastify:master Nov 4, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmuharemagic @jsumners @Uzlopak