New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle early reply correctly #99

Merged

kibertoad merged 1 commit into main from fix/handle-early-reply

Apr 4, 2023

Member

kibertoad commented Apr 4, 2023

Sometimes we reply before we had a chance to instantiate request scope. In that case we shouldn't dispose it (or we'll get an undefined error)

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct


          Handle early reply correctly

cf452b3

kibertoad requested a review from a team

April 4, 2023 11:29

jsumners approved these changes

View reviewed changes

kibertoad merged commit a2f5912 into main

kibertoad deleted the fix/handle-early-reply branch

April 4, 2023 12:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet