Prevented duplicate "request completed" logs #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
reviewed
Mar 9, 2022
Co-authored-by: Manuel Spigolon <[email protected]>
Co-authored-by: Manuel Spigolon <[email protected]>
|
Hi @Eomm, thanks for taking a look at this! I added a few tests cases to verify the logging is correct. Let me know if you need anything else. |
Eomm
approved these changes
Mar 10, 2022
|
@kibertoad would you like to land and release this? |
|
Hey, just checking in on when this is planned to be merged and released. Thanks! |
|
kind reminder @kibertoad |
|
Sorry, missed this. On it. |
kibertoad
approved these changes
Mar 20, 2022
|
Released in 1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that two "request completed" logs were being printed by my Fastify instance following the "incoming request" log. After setting some breakpoints, I narrowed down the cause of this behavior to this plugin, specifically the
onResponsehook controlled by thedisposeOnResponseoption. Removing thereturnfrom the hook callback stopped the extra log from being printed. Alternatively, using async/await will also fix this problem.Checklist
npm run testandnpm run benchmarkand the Code of conduct