Automatically wrap full routes into fastify plugins #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickHeneise
changed the title
mcollina
reviewed
Dec 6, 2019
|
Absolutely not. Wanted to get some feedback and wrap up the code & tests first. Docs are coming in a moment. |
jsumners
reviewed
Dec 6, 2019
index.js
Outdated
| const content = require(file) | ||
| let plugin | ||
|
|
||
| if (content && typeof content === 'object' && content.method) { |
There was a problem hiding this comment.
This check for object-ness is not suffcient. An array will pass this check. You should Object.prototoype.toString.apply(content) === true.
There was a problem hiding this comment.
What do you think of:
Object.prototype.toString.apply(content) === '[object Object]' &&
Object.prototype.hasOwnProperty.call(content, 'method')
?
There was a problem hiding this comment.
Yes, that's what I meant 🤦♂. It's still early morning for me over here.
There was a problem hiding this comment.
No worries :) thanks for the hint. I thought about that before but then though this might be already sufficient but you're right. Adding both checks now.
jsumners
reviewed
Dec 6, 2019
Co-Authored-By: James Sumners <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54
The idea is to reduce the routing files to just the route schema, without wrapping everything into a fastify plugin in every file. It's a cosmetic change.
I'm missing the docs part. Let me know if everything is good to go, then I'll add the part to the README.
Checklist
npm run testandnpm run benchmark