Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge next into master #396

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Merge next into master #396

merged 5 commits into from
Jul 17, 2024

Conversation

jsumners
Copy link
Member

As titled.

* upgrade for next realease

refactor: push 'unit' script at the end

fix: update ci

explicitkly add and remove typescript lugin

test: dont explicitly add ts plugin

test: dont explicitly add ts plugin

* create specific test for unit test test/typescript/*.ts

* fix: nullish needed for non Node.js runtime

* fix: reverse version

* fix: increase timeout

* refactor: use node instead of tap for typescript scripts

* fix: force deletion of @tapjs/typescript

* chore: update test

* chore: update command

* chore: check plugin of tap

* fixup

* chore: fix commands

---------

Co-authored-by: jean <[email protected]>
package.json Outdated Show resolved Hide resolved
climba03003 and others added 3 commits July 13, 2024 07:56
* upgrade for next realease

refactor: push 'unit' script at the end

fix: update ci

explicitkly add and remove typescript lugin

test: dont explicitly add ts plugin

test: dont explicitly add ts plugin

* create specific test for unit test test/typescript/*.ts

* fix: nullish needed for non Node.js runtime

* fix: reverse version

* fix: increase timeout

* refactor: use node instead of tap for typescript scripts

* fix: force deletion of @tapjs/typescript

* chore: update test

* chore: update command

* chore: check plugin of tap

* fixup

* chore: fix commands

---------

Co-authored-by: jean <[email protected]>
@jsumners
Copy link
Member Author

No idea what is wrong with these tests, and I have no time or inclination to figure out Jest.

@jsumners jsumners marked this pull request as ready for review July 15, 2024 10:38
@jean-michelet
Copy link
Contributor

As far as I remember, it didn't always fail, but we should fix this.
Have you tried to increase the default accepted timeout @jsumners?

FYI, I'm very busy with an onboarding for the next 2 weeks and have tons of things todo/learn.
I should have more time after that, but I don't know Jest either so if you have any idea @climba03003

@jean-michelet jean-michelet mentioned this pull request Jul 16, 2024
@climba03003
Copy link
Member

It is the problem I faced for local environment.
I don't knows why it success in Github Actions before, and pop-up again now.

@jean-michelet
Copy link
Contributor

Could this have been introduced by recent additions?

https://github.com/fastify/fastify-autoload/commits/next/

@climba03003
Copy link
Member

Could this have been introduced by recent additions?

It never run successfully in my local environment.

* test: fix jest

* test: remove mixed async and callback
await new Promise(function (resolve) {
const child = exec(`${instance} ${process.cwd()}/test/typescript-jest/integration/instance.ts`);
await new Promise(function (resolve, reject) {
const child = exec(`${instance} "${process.cwd()}/test/typescript-jest/integration/instance.ts"`);

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium test

This shell command depends on an uncontrolled
absolute path
.
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners jsumners merged commit 03512cf into master Jul 17, 2024
30 checks passed
@jsumners jsumners deleted the next branch July 17, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants