-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: autohooks prefix concatenation #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't provide feedback before as I had no strong opinions and have never used the library
If you think this is better, I am behind it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this looks good, I was going to merge, but this is breaking right?
Should we merge to next
?
Changing of test seems to indicate this is breaking, but actually not. The new behavior is introduced in 5.8.1 and it was never tested before. Here is just reverting to behavior to the user most expected one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @climba03003, I've been buried down in work.
This reverts commit d508f82.
This reverts commit d508f82.
This reverts commit 1833842.
Since no core member add value to #376 (comment)
I want to move things forward to users desire behavior.
Fixes #376
As mention in last submitted PR, I believe the long term solution is refactor the code to create a single tree that contain both
hook
andplugin
information.Checklist
npm run test
andnpm run benchmark
and the Code of conduct