Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autohooks prefix concatenation #378

Merged
merged 2 commits into from
May 31, 2024
Merged

fix: autohooks prefix concatenation #378

merged 2 commits into from
May 31, 2024

Conversation

climba03003
Copy link
Member

@climba03003 climba03003 commented May 29, 2024

Since no core member add value to #376 (comment)
I want to move things forward to users desire behavior.

Fixes #376

As mention in last submitted PR, I believe the long term solution is refactor the code to create a single tree that contain both hook and plugin information.

Checklist

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't provide feedback before as I had no strong opinions and have never used the library

If you think this is better, I am behind it

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks good, I was going to merge, but this is breaking right?

Should we merge to next?

@climba03003
Copy link
Member Author

climba03003 commented May 31, 2024

Changing of test seems to indicate this is breaking, but actually not.

The new behavior is introduced in 5.8.1 and it was never tested before.
And that is the one introducing new breaking behavior (or called non-clarified behavior).

Here is just reverting to behavior to the user most expected one.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks @climba03003, I've been buried down in work.

@mcollina mcollina merged commit d508f82 into master May 31, 2024
19 checks passed
@Fdawgs Fdawgs deleted the fix-autohooks-prefix branch May 31, 2024 14:44
@climba03003 climba03003 mentioned this pull request Jun 17, 2024
2 tasks
climba03003 added a commit that referenced this pull request Jun 17, 2024
@climba03003 climba03003 mentioned this pull request Jun 17, 2024
4 tasks
jean-michelet pushed a commit that referenced this pull request Jun 17, 2024
jean-michelet added a commit that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fastify 5.8.2 and autohooks produces "route already declared" error
3 participants