Achieve 100% test coverage #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index.ts if typescriptSupport is not enabled
|
Um... I'm going to investigate. |
jean-michelet
commented
Mar 18, 2024
Closed
|
Waiting for #371 to be merged. |
|
You are targetting master, but #371 is targetting next |
|
Can we achieve this on master instead? I think it would be a moving target on next. |
Should I try to fix the failing TS test here? |
|
The test that's failing here and the one in 371 are different I think So for this PR, I'd suggest making the tests pass and merging to |
jean-michelet
commented
Apr 21, 2024
| const isSWCNodeRegister = process._preload_modules && process._preload_modules.includes('@swc-node/register') | ||
| const isSWCRegister = process._preload_modules?.includes('@swc/register') | ||
| const isSWCNodeRegister = process._preload_modules?.includes('@swc-node/register') | ||
| /* istanbul ignore next - OS specific */ | ||
| const isSWCNode = typeof process.env._ === 'string' && process.env._.includes('.bin/swc-node') |
There was a problem hiding this comment.
Never evaluated on windows...
|
Ready For Review |
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #369
I failed to cover some branches, so I have removed them. If you can find a way to fully evaluate these branches, please let me know. However, it's possible that they may be obsolete.
I've created an
issuesfolder for issues related tests, which will need to follow this pattern:test/issues/<issue-number>/test.js. Since we're testing the autoloader, we need to create fixtures. This is why I chose to create a folder named after the issue instead of placing<issue-number>.jsdirectly.If you agree with this approach, I will update this PR to reflect these changes.