Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing type routeParams #153

Merged
merged 2 commits into from
Apr 16, 2021
Merged

fix: add missing type routeParams #153

merged 2 commits into from
Apr 16, 2021

Conversation

arthur-fontaine
Copy link
Contributor

@arthur-fontaine arthur-fontaine commented Apr 7, 2021 •
edited
Loading

related to #134

climba03003
climba03003 reviewed Apr 7, 2021
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an unit test for this option in typescript ?

@arthur-fontaine
Copy link
Contributor Author

I can try but I have never written a test before...

@Eomm
Copy link
Member

Eomm commented Apr 13, 2021

I can try but I have never written a test before...

YOu may take inspiration from the tests already in place in this folder:
https://github.com/fastify/fastify-autoload/blob/master/test/typescript/

@arthur-fontaine
Copy link
Contributor Author

I don't know if the only changes I've written are enough...
the commit

climba03003
climba03003 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

RafaelGSS
RafaelGSS approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mcollina
mcollina approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3ab0101 into fastify:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 climba03003 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arthur-fontaine @Eomm @mcollina @climba03003 @RafaelGSS