chore: 582 - improving test coverage #608
Conversation
Signed-off-by: Sasa Cvetkovic <[email protected]>
| if (largeArrayMechanism !== 'default') { | ||
| if (largeArrayMechanism === 'json-stringify') { | ||
| functionCode += `if (arrayLength && arrayLength >= ${largeArraySize}) return JSON.stringify(obj)\n` | ||
| } else { |
There was a problem hiding this comment.
because validLargeArrayMechanisms -> this throw will never happen (we get an early throw if largeArrayMechanism is not default or json-stringify) so no need for it -> already covered by tests
| @@ -663,8 +659,6 @@ function buildArrayTypeCondition (type, accessor) { | |||
| return buildArrayTypeCondition(subType, accessor) | |||
| }) | |||
| condition = `(${conditions.join(' || ')})` | |||
| } else { | |||
There was a problem hiding this comment.
this case is not possible because validation of types schema is invalid: data/properties/ids/type must be equal to one of the allowed values -> already covered by tests
There was a problem hiding this comment.
which line is already handling this already?
There was a problem hiding this comment.
Line 32 in c83cc32
switch
There was a problem hiding this comment.
concrete line
Line 88 in c83cc32
|
serializer.js: 98.85 -> 100% |
#582
Improving test coverage part 1
Checklist
npm run testandnpm run benchmarkand the Code of conduct