Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ajv.errorsText instead of custom error message #79

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Use Ajv.errorsText instead of custom error message #79

merged 1 commit into from
Aug 3, 2021

Conversation

tommarien
Copy link
Contributor

This provides context to the message you are getting, instead of just saying must be an integer, from now on you will get env/VARIABLE must be an integer.

closes #78

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added (not necessary improves existing functionality)
  • commit message and code follows the Developer's Certification of Origin
    and the Code of conduct

@tommarien
Use Ajv.errorsText instead of custom error message
5024477 
This provides context to the message you are getting, instead of just saying must be an integer, from now on you will get env/VARIABLE must be an integer.
mcollina
mcollina approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1091363773

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.176%
Totals Coverage Status
Change from base Build 1051957784: 0.0%
Covered Lines: 41
Relevant Lines: 42
💛 - Coveralls

@Eomm Eomm merged commit 38dbbc9 into fastify:master Aug 3, 2021
@tommarien tommarien deleted the use-ajv-errorstext branch August 3, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Ajv.errorsText instead of errors.map, otherwise you loose context
4 participants
@tommarien @coveralls @mcollina @Eomm