Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.data in the README file has to be config.ALLOWED_HOSTS? #146

Closed
2 tasks done
aderchox opened this issue Mar 4, 2023 · 1 comment · Fixed by #149
Closed
2 tasks done

config.data in the README file has to be config.ALLOWED_HOSTS? #146

aderchox opened this issue Mar 4, 2023 · 1 comment · Fixed by #149
Labels
good first issue Good for newcomers

Comments

@aderchox
Copy link
Contributor

aderchox commented Mar 4, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

In the README file, below an example you have this comment:

// config.data => ['127.0.0.1', '0.0.0.0']

but it seems that it has to be this:

// config.ALLOWED_HOSTS => ['127.0.0.1', '0.0.0.0']

I tried on Runkit too, config.data logs undefined. Or I might be missing something...
@Eomm
Copy link
Member

Eomm commented Mar 7, 2023

Thanks for reporting and yes you are right!
Would you like to send a Pull Request to address this issue?

@climba03003 climba03003 added the good first issue Good for newcomers label Mar 7, 2023
aderchox added a commit to aderchox/env-schema that referenced this issue Mar 7, 2023
@aderchox
fix: fixes issue fastify#146
711ad1c 
The commented result in the example snippet in the README file is corrected.
aderchox added a commit to aderchox/env-schema that referenced this issue Mar 7, 2023
@aderchox
docs: Resolve the issue fastify#146.
29e345d 
The commented result in the example snippet in the README file is corrected.
@climba03003 climba03003 linked a pull request Mar 7, 2023 that will close this issue
docs: Resolve the issue #146. #149
Merged
4 tasks
@aderchox aderchox closed this as completed Mar 7, 2023
Eomm pushed a commit that referenced this issue Mar 7, 2023
@aderchox
docs: Resolve the issue #146. (#149)
f61a444 
The commented result in the example snippet in the README file is corrected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Resolve the issue #146. aderchox/env-schema
3 participants
@Eomm @climba03003 @aderchox