Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete existing file when uploading image #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: delete existing file when uploading image #45

wants to merge 1 commit into from

Conversation

JP-sDEV
Copy link

@JP-sDEV JP-sDEV commented Oct 23, 2024 •
edited
Loading

Checklist

fixes: #45

@JP-sDEV
Copy link
Author

JP-sDEV commented Oct 23, 2024

note: src/routes/api/tasks/index.ts has been linted

@jean-michelet
Copy link
Contributor

jean-michelet commented Oct 23, 2024 •
edited
Loading

I will take a look in the week, but you must add a test to prove that the file was indeed deleted.

climba03003
climba03003 requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run linter before pushing, it contains too much style changes that make this PR hard to review.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climba03003 climba03003 climba03003 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JP-sDEV @jean-michelet @climba03003