-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance in searchstream #36
Conversation
Also deoptimization traces are gone.
|
I think this PR is actually good enough performance gain for this iteration, so that even @mcollina would be happy :-D as it does not only shaves some yoctoseconds. So we improved the performance from about 3,5 GB/s to 10-12 GB/s. |
will take a look later tonight, need to wrap up version release at work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Uzlopak BTW, I've published a beta version of the package and tried running fastify-multipart as well as multer v2 tests against it, and all of them are still passing, so looks like your optimizations didn't break anything :) For the first public release I still want to wait for #26 |
@kibertoad |
Unit tests are green, so I think the change provides an equivalent functionality.
Benchmark:
Checklist
npm run test
andnpm run benchmark
and the Code of conduct