Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace mocha and chai with tap #123

Merged
merged 8 commits into from
Sep 28, 2023
Merged

chore: replace mocha and chai with tap #123

merged 8 commits into from
Sep 28, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 23, 2023

Checklist

@Uzlopak Uzlopak mentioned this pull request Aug 24, 2023
4 tasks
@Uzlopak Uzlopak marked this pull request as ready for review August 24, 2023 10:05
@Uzlopak Uzlopak requested a review from kibertoad August 24, 2023 10:05
@gurgunday
Copy link
Member

It all LGTM, will just test it with my changes

Co-authored-by: Gürgün Dayıoğlu <[email protected]>
@gurgunday
Copy link
Member

Maybe we can merge this next

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a conflict

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 28, 2023

@kibertoad
@Eomm
@gurgunday

PTAL

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit be5e0b0 into master Sep 28, 2023
18 checks passed
@Uzlopak Uzlopak deleted the use-tap branch September 28, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants