Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Avoid the unnecessary import of typing_extensions in newer Python versions #1048

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

✨ Avoid the unnecessary import of typing_extensions in newer Python versions #1048

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ec22523
Avoid the unnecessary import of typing_extensions
horta Nov 12, 2024
da1d691
Update typer/main.py
horta Nov 13, 2024
4b5f804
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Nov 13, 2024
b7ca7d5
Importing from _typing instead
horta Nov 13, 2024
fe16dd0
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Nov 13, 2024
254944b
Merge branch 'master' into avoid-typing-extensions
svlandeg Dec 26, 2024
d347a95
import Literal directly to make ruff happy
svlandeg Dec 26, 2024
bff343c
Merge branch 'master' into avoid-typing-extensions
svlandeg Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion typer/_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
Union,
)

from typing_extensions import Literal, get_args, get_origin
if sys.version_info >= (3, 9):
from typing import Literal, get_args, get_origin
else:
from typing_extensions import Literal, get_args, get_origin

if sys.version_info < (3, 10):

Expand Down
6 changes: 5 additions & 1 deletion typer/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
from uuid import UUID

import click
from typing_extensions import get_args, get_origin

if sys.version_info >= (3, 9):
from typing import get_args, get_origin
else:
from typing_extensions import get_args, get_origin

from ._typing import is_union
horta marked this conversation as resolved.
Show resolved Hide resolved
from .completion import get_completion_inspect_parameters
Expand Down
5 changes: 4 additions & 1 deletion typer/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
from copy import copy
from typing import Any, Callable, Dict, List, Tuple, Type, cast

from typing_extensions import Annotated, get_args, get_origin, get_type_hints
if sys.version_info >= (3, 9):
from typing import Annotated, get_args, get_origin, get_type_hints
else:
from typing_extensions import Annotated, get_args, get_origin, get_type_hints

from .models import ArgumentInfo, OptionInfo, ParameterInfo, ParamMeta

Expand Down
Loading