Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for extending typer apps without passing a name, add commands to the top level #1037

Merged
merged 18 commits into from
Dec 3, 2024

Conversation

patrick91
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 1, 2024

📝 Docs preview for commit c01e9e3 at: https://7de33943.typertiangolo.pages.dev

@patrick91 patrick91 added the feature New feature, enhancement or request label Nov 1, 2024
Copy link

github-actions bot commented Dec 2, 2024

Copy link

github-actions bot commented Dec 2, 2024

Copy link

github-actions bot commented Dec 2, 2024

Copy link

github-actions bot commented Dec 2, 2024

@patrick91 patrick91 marked this pull request as ready for review December 2, 2024 15:55
tiangolo
tiangolo previously approved these changes Dec 2, 2024
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is looking great. 🚀

A few nitpicks because I'm super picky with docs. 😅

docs/tutorial/splitting-apps.md Outdated Show resolved Hide resolved
docs/tutorial/splitting-apps.md Outdated Show resolved Hide resolved
docs/tutorial/splitting-apps.md Outdated Show resolved Hide resolved
docs/tutorial/splitting-apps.md Outdated Show resolved Hide resolved
docs/tutorial/splitting-apps.md Outdated Show resolved Hide resolved
docs/tutorial/splitting-apps.md Outdated Show resolved Hide resolved
docs/tutorial/splitting-apps.md Outdated Show resolved Hide resolved
docs/tutorial/splitting-apps.md Outdated Show resolved Hide resolved
docs_src/splitting_apps/users/add.py Outdated Show resolved Hide resolved
docs_src/splitting_apps/users/delete.py Outdated Show resolved Hide resolved
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is looking great. 🚀

A few nitpicks because I'm super picky with docs. 😅

@tiangolo tiangolo dismissed their stale review December 2, 2024 23:31

I approved by mistake, intended to comment 😅

Copy link

github-actions bot commented Dec 3, 2024

Copy link

github-actions bot commented Dec 3, 2024

Copy link

github-actions bot commented Dec 3, 2024

Copy link

github-actions bot commented Dec 3, 2024

@tiangolo tiangolo changed the title ✨ Add support for extending typer apps without passing a name ✨ Add support for extending typer apps without passing a name, add commands to the top level Dec 3, 2024
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I tweaked the docs a bit more and this is ready now. Ready the chicken! 🐔 🚀

@tiangolo tiangolo merged commit 2681205 into master Dec 3, 2024
23 checks passed
@tiangolo tiangolo deleted the feature/add-typer-without-grouping branch December 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature, enhancement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants