✏️ Fix a few typos in the source and documentation #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Docs preview for commit ed7c0cb at: https://1783ccf2.typertiangolo.pages.dev Modified Pages |
svlandeg
changed the title
svlandeg
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Hi, thanks for the contribution! We appreciate it.
The typo fixes in the documentation and source comments like fine. 👍
However, I would refrain from changing convertor to converter as this is used as an argument in various public functions in main.py, and it would break people's code who call these functions with convertor=x. And while convertor is probably less frequently used than converter, I still think it's a valid term, so as such I would just keep that one across all occurrences. Can you make that edit? Thanks! 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes typos in various locations in the application.