🔧 Reuse database url from config in alembic setup (#1229)

fastapi · Jul 30, 2024 · b5b2929 · b5b2929
1 parent b15d482
commit b5b2929
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/backend/app/alembic/env.py b/backend/app/alembic/env.py
@@ -19,6 +19,7 @@
 # target_metadata = None
 
 from app.models import SQLModel  # noqa
+from app.core.config import settings # noqa
 
 target_metadata = SQLModel.metadata
 
@@ -29,12 +30,7 @@
 
 
 def get_url():
-    user = os.getenv("POSTGRES_USER", "postgres")
-    password = os.getenv("POSTGRES_PASSWORD", "")
-    server = os.getenv("POSTGRES_SERVER", "db")
-    port = os.getenv("POSTGRES_PORT", "5432")
-    db = os.getenv("POSTGRES_DB", "app")
-    return f"postgresql+psycopg://{user}:{password}@{server}:{port}/{db}"
+    return str(settings.SQLALCHEMY_DATABASE_URI)
 
 
 def run_migrations_offline():

diff --git a/backend/app/core/config.py b/backend/app/core/config.py
@@ -51,7 +51,7 @@ def server_host(self) -> str:
     POSTGRES_SERVER: str
     POSTGRES_PORT: int = 5432
     POSTGRES_USER: str
-    POSTGRES_PASSWORD: str
+    POSTGRES_PASSWORD: str = ""
     POSTGRES_DB: str = ""
 
     @computed_field  # type: ignore[misc]