Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-arrange header | Sticky header | Improve UX with proper keyboard handler #3938

Merged
merged 10 commits into from
Oct 13, 2024

Conversation

knighthat
Copy link

Keyboard handler

  • Keyboard will now close once when search bar is out of focus.
  • Back button from other screen will not re-enable keyboard
  • Keyboard will close on certain (intended) actions.

Tab's header rearrangement

Before

After

Sticky header

Before

Only Songs tab has sticky header

StickyHeader-Before.mov

After

Now all tabs have sticky header

StickyHeader-After.mov

@fast4x fast4x merged commit 0e2fcaa into fast4x:master Oct 13, 2024
@fast4x
Copy link
Owner

fast4x commented Oct 13, 2024

Great

@knighthat knighthat deleted the tab-header branch October 19, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants