website - various changes #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change reveal script add additional div inside revial container, change languageselect type and style, add globe icon on top, language constant is automatically generated from the options
add events for languageselect creation
unnecessary reveal code deleted
change styling of languageselect add reveal style
unnecessary code deleted, add script for languageselect, changing the language no longer triggers a reload
change parameter
remove unnecessary code
add portuges
mobile optimization
Accessibillity: add missing alt text change visibility of loading screen in noscript, Placeholder replaced with default language, this allows a good display of the page when Javascript is disabled SEO: Add Meta Descriptions
accessibility for globeicon improved, unnecessary code removed
reveal customized to allow display of the website without javascript
hide globeicon, darklighticon and languageselect using noscript, as the functions are not accessible without javascript
<noscript> does not work if the execution of javascript has been blocked by the add-on “NoScript”. Solution integrated via css and js
<noscript> does not work if the execution of javascript has been blocked by the add-on “NoScript”. Solution integrated via css and js
codeoptimation
code improvement
color of languageselect changed
add key functionality on language select
add tabindex
tabindex improvement
tabindex improvements
add obtainium
change size of obtainium button
|
now also update the dimensions of the free space inside the obtainium button and change size in readme to default |
|
Wow amazing, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some changes in docs.
You can view the changes at https://martkol.github.io/RiMusic/
The obtainium button still has the wrong size, as this can only be accessed via raw. The corrected button is available in the pull.