Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant search words after # #3779

Closed
faustaahmad opened this issue Sep 25, 2024 · 7 comments
Closed

Cant search words after # #3779

faustaahmad opened this issue Sep 25, 2024 · 7 comments
Labels
bug Something isn't working Fixed

Comments

@faustaahmad
Copy link

Steps to reproduce the bug

・Press search
・Search for anything but with added # at random position
or could search for #####
・Words after first/leftmost # will be excluded from the query

Expected behavior

Can search #

Actual behavior

Words after # excluded from the query

Screenshots/Screen recordings

#### results in empty search query

Logs

No response

RiMusic version

0.6.52

Android version

Android 11

Additional information

If possible, please check other symbols too

@faustaahmad faustaahmad added the bug Something isn't working label Sep 25, 2024
@knighthat
Copy link

can you give me an example of a valid song that contains # in the title?

@faustaahmad
Copy link
Author

can you give me an example of a valid song that contains # in the title?

I dont know any song with # on its title
Often I need to use # as a keywords to search in youtube video
For example: "CC#2 OST Arknights"

@knighthat
Copy link

Thank you for the example. I'll review it once I have time

knighthat added a commit to knighthat/RiMusic that referenced this issue Sep 29, 2024
@knighthat
Copy link

@faustaahmad I have implemented a fix to this, the video you gave as the example is now searchable on the platform. Please wait for the next release

Screenshot_20240929_182659

@fast4x fast4x added the Fixed label Oct 1, 2024
@fast4x
Copy link
Owner

fast4x commented Oct 1, 2024

Fixed, available from version 0.6.55

fast4x added a commit that referenced this issue Oct 3, 2024
Improved search clean for # special character #3779
@knighthat
Copy link

@fast4x this is even worst than my implementation, mine turns any string into url-safe string, yours outright deletes those characters, please reconsider this implementation #3826.

@fast4x
Copy link
Owner

fast4x commented Oct 4, 2024

It's just implemented and available from version 0.6.55

@fast4x fast4x closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed
Projects
None yet
Development

No branches or pull requests

3 participants