Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes when there's no internet connection #164

Closed
Gthbacc opened this issue Dec 2, 2023 · 18 comments
Closed

App crashes when there's no internet connection #164

Gthbacc opened this issue Dec 2, 2023 · 18 comments
Labels
bug Something isn't working enhancement New feature or request Fixed

Comments

@Gthbacc
Copy link

Gthbacc commented Dec 2, 2023

This issue wasnt present before adding the download feature.
Also if it helps: when there is an internet connection, as soon as the app opens, the download notification pops up, stays for 5 seconds and then closes.
Thanks for maintaining the app btw.

@fast4x
Copy link
Owner

fast4x commented Dec 2, 2023

Any questions, if no internet connection.
does it crash when you open the app or play a song?
If you close and reopen the app, is the download successful or not?

@fast4x fast4x added the bug Something isn't working label Dec 2, 2023
@Snyret
Copy link

Snyret commented Dec 2, 2023

Any questions, if no internet connection.
does it crash when you open the app or play a song?
If you close and reopen the app, is the download successful or not?

I have the same notification issue, I suppose it's only the app scanning the downloads on the device (The local files still don't load btw).

The songs also take a few seconds more to load since the invidious and piped support was added.

@fast4x
Copy link
Owner

fast4x commented Dec 2, 2023

Any questions, if no internet connection.
does it crash when you open the app or play a song?
If you close and reopen the app, is the download successful or not?

I have the same notification issue, I suppose it's only the app scanning the downloads on the device (The local files still don't load btw).

The songs also take a few seconds more to load since the invidious and piped support was added.

The local files still don't load btw, actually have a bug...

@fast4x
Copy link
Owner

fast4x commented Dec 2, 2023

I'll add a internet connection checker, thanks for feedback

@fast4x fast4x added enhancement New feature or request In progress labels Dec 2, 2023
@Gthbacc
Copy link
Author

Gthbacc commented Dec 2, 2023

Any questions, if no internet connection.
does it crash when you open the app or play a song?
If you close and reopen the app, is the download successful or not?

It immediately crashed upon opening the app. Also as Snyret mentioned, it's probably just scanning for a download. There's no indication whether the download is successful or not.
Also there's one more issue: if a playlist is synced when there's no connection, all the songs immediately get removed and the playlist is basically dead. All the icons grey out and it's just sitting there on the screen (cant remove them or anything)

@fast4x
Copy link
Owner

fast4x commented Dec 2, 2023

Your Android version?
In the next release, I will insert a different function to check the status of the internet connection, should solve the problem.

@Gthbacc
Copy link
Author

Gthbacc commented Dec 2, 2023

Your Android version?

  1. Thanks for your work.

@fast4x
Copy link
Owner

fast4x commented Dec 3, 2023

Fixed, available from version 0.6.12
I think I figured it out, if he shows up again, let me know.

@fast4x fast4x added Fixed and removed In progress labels Dec 3, 2023
fast4x added a commit that referenced this issue Dec 9, 2023
@fast4x fast4x closed this as completed Dec 9, 2023
@Gthbacc
Copy link
Author

Gthbacc commented Dec 10, 2023

Hey. Thought I should inform you that both issues mentioned in this thread still exist in the new update as well. Even uninstalled the app and re-installed it again. Not sure what the issue is. Thanks.

@eerqx
Copy link

eerqx commented Dec 10, 2023


Fixed, available from version 0.6.12 I think I figured it out, if he shows up again, let me know.

It's not fixed in this update also and the changelog also not mentions it.

@fast4x
Copy link
Owner

fast4x commented Dec 10, 2023

ok I check better, thanks

@fast4x fast4x reopened this Dec 10, 2023
@fast4x
Copy link
Owner

fast4x commented Dec 10, 2023

Can you tell me more about the error?
The thing is very strange

@fast4x
Copy link
Owner

fast4x commented Dec 10, 2023


Fixed, available from version 0.6.12 I think I figured it out, if he shows up again, let me know.

It's not fixed in this update also and the changelog also not mentions it.

It is mentioned in What's Changed

@fast4x fast4x removed the Fixed label Dec 10, 2023
@fast4x
Copy link
Owner

fast4x commented Dec 10, 2023


Fixed, available from version 0.6.12 I think I figured it out, if he shows up again, let me know.

It's not fixed in this update also and the changelog also not mentions it.

Does your device have Android 11?

@Gthbacc
Copy link
Author

Gthbacc commented Dec 10, 2023

Can you tell me more about the error?
The thing is very strange

Honestly not much to say. I think it started happening after the app became capable of playing local files. Maybe it had sth to do with that?

@fast4x
Copy link
Owner

fast4x commented Dec 10, 2023

Okay, I think I found the problem on Android 11, maybe even on the 10. I’ll do a test.

@fast4x fast4x added the Fixed label Dec 10, 2023
@fast4x
Copy link
Owner

fast4x commented Dec 10, 2023

Fixed, available from version 0.6.13

@eerqx
Copy link

eerqx commented Dec 11, 2023

Fixed, available from version 0.6.12 I think I figured it out, if he shows up again, let me know.

It's not fixed in this update also and the changelog also not mentions it.

Does your device have Android 11?

A10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Fixed
Projects
None yet
Development

No branches or pull requests

4 participants