Merge pull request #14 from fast-radius/td-cleanup

Remove MockClient implementation
fast-radius · Sep 30, 2020 · f920456 · f920456
2 parents 281ccdf + cda0924
commit f920456
Show file tree

Hide file tree

Showing 9 changed files with 5 additions and 83 deletions.
diff --git a/config/dev.exs b/config/dev.exs
diff --git a/config/prod.exs b/config/prod.exs
diff --git a/config/test.exs b/config/test.exs
@@ -1,3 +1,3 @@
 use Mix.Config
 
-config :smartsheet, client: Smartsheet.MockClient
+config :smartsheet, api_key: "Test123"
diff --git a/lib/smartsheet/mock_client/mock_client.ex b/lib/smartsheet/mock_client/mock_client.ex
diff --git a/lib/smartsheet/mock_client/request_fixtures.ex b/lib/smartsheet/mock_client/request_fixtures.ex
diff --git a/lib/smartsheet/parse_response.ex b/lib/smartsheet/parse_response.ex
@@ -89,12 +89,12 @@ defmodule Smartsheet.ParseResponse do
     Enum.map(columns, fn column -> struct(Smartsheet.Column, column) end)
   end
 
-  def success_response(response = %HTTPoison.Response{}, data) do
+  defp success_response(response = %HTTPoison.Response{}, data) do
     formatted_response = Smartsheet.Response.format(response)
     {:ok, formatted_response, data}
   end
 
-  def error_response(response = %HTTPoison.Response{}) do
+  defp error_response(response = %HTTPoison.Response{}) do
     formatted_response = Smartsheet.Response.format(response)
     {:error, formatted_response}
   end

diff --git a/...artsheet/mock_client/response_fixtures.ex → lib/smartsheet/response_fixtures.ex b/...artsheet/mock_client/response_fixtures.ex → lib/smartsheet/response_fixtures.ex
diff --git a/mix.exs b/mix.exs
@@ -6,7 +6,7 @@ defmodule Smartsheet.MixProject do
       app: :smartsheet,
       description: "HTTP wrapper around the Smartsheet API",
       package: package(),
-      version: "2.0.0",
+      version: "2.1.0",
       elixir: "~> 1.10",
       start_permanent: Mix.env() == :prod,
       deps: deps()

diff --git a/test/smartsheet/http_client_test.exs b/test/smartsheet/http_client_test.exs
@@ -81,7 +81,7 @@ defmodule Smartsheet.HttpClientTest do
     test "it appends Authorization Headers" do
       headers = {"Content-Type", "application/json"}
 
-      assert [{:Authorization, "Bearer "} | {"Content-Type", "application/json"}] ==
+      assert [{:Authorization, "Bearer Test123"} | {"Content-Type", "application/json"}] ==
                HttpClient.process_request_headers(headers)
     end
   end