Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build ESM, CommonJS and update IIFE modules #18

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Build ESM, CommonJS and update IIFE modules #18

merged 1 commit into from
Jan 3, 2022

Conversation

vitaliytv
Copy link
Contributor

@fasiha fasiha merged commit 3f654dd into fasiha:master Jan 3, 2022
@fasiha
Copy link
Owner

fasiha commented Jan 3, 2022

Thanks for this! Quick question, when I run npm run compile, I see some whitespace differences in dist/mudder.cjs and index.js, do you know if there's a minify step missing in esbuild.mjs?

@fasiha
Copy link
Owner

fasiha commented Jan 3, 2022

Ah, never mind @vitaliytv! When I run npm run build, I get a clean diff, it's just when I run npm run compile that the whitespaces appear. Thank you SO MUCH for this, I appreciate it a lot! Cutting a new npm release right now 😄!

@vitaliytv
Copy link
Contributor Author

Ah, never mind @vitaliytv! When I run npm run build, I get a clean diff, it's just when I run npm run compile that the whitespaces appear. Thank you SO MUCH for this, I appreciate it a lot! Cutting a new npm release right now 😄!

Thank you for library and fast reaction

@fasiha fasiha mentioned this pull request Feb 3, 2022
Closed
@fasiha fasiha mentioned this pull request Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitaliytv @fasiha