Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT Hold mode removed in HA 2022.9 #153

Closed
clemente3905 opened this issue Sep 9, 2022 · 16 comments
Closed

MQTT Hold mode removed in HA 2022.9 #153

clemente3905 opened this issue Sep 9, 2022 · 16 comments

Comments

@clemente3905
Copy link

Hi all, with the last update (2022.9) of HA core, the hold mode has been removed.
As a result the thermostat integration in HA is no longer working.

Is there any workaround other than avoid upgrading home assistant?
@labodj
Copy link
Contributor

labodj commented Sep 9, 2022

@clemente3905 if you want you can try my release HERE
It is compatible with 2022.9
Just send to the thermostat as a normal update at http://THERMOSTAT_IP/firmware?

@clemente3905
Copy link
Author

@labodj First of all THANKS!
Then, this will be the very first time that I have to upgrade a Thermostat.
Can you please guide me on what steps do I have to perform to have them again online and working?
I imagine something like

  1. Download and save the .bin file on a PC
  2. open in a browser http://THERMOSTAT_IP/firmware?new_firmware.bin
  3. Logging on the termostat (which wifi? which User? which password?)
  4. Re-configure the termostat as it was before
  5. How Do I change the config.yaml in home assistant to have the thermostat work again? Just remove the away-mode?
  6. What abaout the hold mode in which I usually select manual/scheduler/eco? Is it still working in 2022.9?

Thanks again for your help and forgive if I ask lots of questions, but would really love to avoid damage...

@labodj
Copy link
Contributor

labodj commented Sep 9, 2022 •
edited
Loading

@clemente3905

I suppose you are running fashberg firmware on your thermostat.

I suppose it's connected to your wifi network.

I suppose it's configured on your home assistant.

Download the bin fine.
Open a web browser
Go to http://THERMOSTAT_IP/
There is no user, and no password
Click on "update firmware"
Select the file, click "update firmware"
Wait for reboot, it will retain your settings
Done
Nothing else to reconfigure

@clemente3905
Copy link
Author

Going to test right now.
Thanks
Come back in any case with results

@clemente3905
Copy link
Author

clemente3905 commented Sep 9, 2022 •
edited
Loading

@labodj
No luck...
I flashed all thermostat but after upgrade HA to 2022.9 again they all went KO.
I then modified the config.yaml to remove the "hold" reference, but this time devices became unresponsive, I am no more able to change their state.

For instance, this is the part of the config.yaml relative to the thermostat

climate: 
    - name: Corridoio
      unique_id: 1gf43d
      availability_topic: "corridoio/tele/LWT"
      payload_available: "Online"
      payload_not_available: "Offline"
      action_topic: "corridoio/stat/things/thermostat/properties/action"
      action_template: "{{value}}"
      temperature_command_topic: "corridoio/cmnd/things/thermostat/properties/targetTemperature"
      temperature_state_topic: "corridoio/stat/things/thermostat/properties/targetTemperature"
      temperature_state_template: "{{value}}"
      current_temperature_topic: "corridoio/stat/things/thermostat/properties/temperature"
      current_temperature_template: "{{value}}"
      mode_command_topic: "corridoio/cmnd/things/thermostat/properties/mode"
      mode_state_topic: "corridoio/stat/things/thermostat/properties/systemMode"
      mode_state_template: "{{value}}"
      fan_mode_command_topic: "corridoio/cmnd/things/thermostat/properties/fanMode"
      fan_mode_state_topic: "corridoio/stat/things/thermostat/properties/fanMode"
      fan_mode_state_template: "{{value}}"
      hold_command_topic: "corridoio/cmnd/things/thermostat/properties/holdState"
      hold_state_topic: "corridoio/stat/things/thermostat/properties/holdState"
      hold_state_template: "{{value}}"
      hold_modes: [ "scheduler", "manual","eco" ]
      payload_on: "ON"
      payload_off: "OFF"
      modes: [ "heat", "cool", "fan_only", "off" ]
      min_temp: 10
      max_temp: 35
      temp_step: 1
      precision: 0.5

@labodj
Copy link
Contributor

labodj commented Sep 9, 2022 •
edited
Loading

@clemente3905 you don't need that on home assistant, this firmware supports autodiscovery.
So

  • delete that part from home assistant config
  • restart your home assistant to reload the new config
  • go to http://Thermostat_IP/
  • click on "configure network"
  • check MQTT config
  • select "Support Autodiscovery for Home Assistant using MQTT"
  • click "save config and reboot"
  • Home assistant should discover the "new" device

I'm using it this way, so I can confirm it works as expected.

@clemente3905
Copy link
Author

clemente3905 commented Sep 9, 2022 •
edited
Loading

@labodj
There is something that is not working...
I made as you said but I get a new entity without valid value

image

If I go inside the MQTT info I can see that everything seems OK, except the fact that in the value template it doesn't use '{{value}}' for the template.

I remember that I had an issue with "standard" fasberg and I had to separate JSON in single argument to have them work.
It should be this?

image
If you look at message 14 you will notice that there is a } missing and also a warning at the beginning of message 20...

@labodj
Copy link
Contributor

labodj commented Sep 9, 2022 •
edited
Loading

@clemente3905
and this is mine
image

The warning on log is normal, just disable logging, it's useless for you.
your mcuid properties is bugged.

It's not the firmware, it's some config wrong on your side or some leftover.
Try to clean(delete) MQTT topics, remove devices and configs from home assistant.

Reboot everything e retry.

@clemente3905
Copy link
Author

Ok, thanks for your patience and the help jacopo. I still don't know how but I will buy you a beer for sure!
It is clear to me how to remove devices (simply comment the configuration.yaml since they are all manually configured).
It is NOT clear to me how to clean or delete MQTT topics from HA or clean leftovers.
For the other "autodiscovered" climate devices, I will simply go to Settings->Devices and delete them one by one.

Is it correct?

@fashberg
Copy link
Owner

he @clemente3905 , check out 1.21.

Hold-State is also deprecated. I've implemented Away and Scheduler/Auto with "Presets", just use the autoconfiguration, it works fine on my test-device

@clemente3905
Copy link
Author

Hi @fashberg .
I used 1.21 in one of my thermostat.
As with @labodj beta 1.19, using autodiscovery the thermostat is not working. on my side.
Again, same version but using a manual configuration is working.
If it can be interested, I always have an error on the json file, specifically a } is missing and this destroy the JSON file.
My workaround is to send all values singularly and change the template in the yaml configuration to {{value}}

Don't know if this can be the issue but this solved my problem.

If you need me to post some additional log/info please tell me.

@fashberg
Copy link
Owner

Hey @clemente3905 ,

Which HA version do you have?
Is there anything in the HA logs?

Probably it's my change in 1.12 with adding profiles.
You can safely downgrade to 1.20 and test, if auto discover is working there.

@clemente3905
Copy link
Author

clemente3905 commented Sep 15, 2022 •
edited
Loading

@fashberg
I'm using HA core 2022.9.1 on a virtual machine.
I ALWAYS used your firmware for my BAC but NEVER worked if I try autodiscovery OR if I do NOT select single value in the JSON.
When I installed it at the beginning (it was the 1.19 beta fas), I realized that the "full" json is not valid, due to the missing } I show you before.
Following images is taken directly from info of the thermostat:

image

The MCU-ID map is missing the closing "} so when compiling a full json file it is not valid and it is not parsed correctly.

Please note that the same problem appears even if I use manual configuration WITHOUT the "single value" in the json file and without manually modifying the template into {{value}} in the configuration.yaml, so IMHO it is NOT a problem in the autodiscovery.
I do not know if the problem is due to my specific item (but I have 5 identical BAC-002 and ALL of them show the same behaviour), but I'm not able to have it work in autodiscovery, because I do not get any control other than the preset mode (so no temperature, no fan control, no mode).
Do you think I will have to try 1.20?
Thanks for help and hope I can be useful to fix this bug

@labodj
Copy link
Contributor

labodj commented Sep 15, 2022

@clemente3905 @fashberg
I can confirm that 1.21 is working flawlessly in HA 2022.9.4 with autodiscovery.

Just a note, I always used "Send all properties also in separate MQTT messages"

@clemente3905
Copy link
Author

@fashberg @labodj
If it can be useful, please find hereafter the diagnostic of the MQTT integration where I have 5 "manually integrated" thermostats and 1 autodiscovered (not working) thermostat. This one is called Salotto.
Be careful, I also have a manual integrated Salotto, which is correctly working.
Please note that I check both the autodiscovery and the "Send all properties also in separate MQTT messages"

mqtt-52931e3cbd611ec5dcd2eaf18dc50d47-Salotto-78df34da27a3aa8ca58905f9843aefee.json.txt

fashberg added a commit to fashberg/WAdapter that referenced this issue Oct 2, 2022
@fashberg
Fixes for WThermostatBeca 1.22
c9a35c2 
* Fixes mqtt reconnect
* Fixes invalidJsonCharacters
(fashberg/WThermostatBeca#153)
@fashberg
Copy link
Owner

fashberg commented Oct 2, 2022

it's was not the non-closing { , it was the quote (") in the MCU ID. The MCUID broke json response.
Please check 1.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@labodj @fashberg @clemente3905