Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js-plugin-electron): dependencies unintentionally marked as external #2012

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

JellyBrick
Copy link
Contributor

@JellyBrick JellyBrick commented Dec 20, 2024

Description: fixed an issue where dependencies were unintentionally marked as external

  • caused by
    opts.farm.compilation.external.push('electron');
    • This code was causing dependencies, such as electron-* that matched the electron (regex), to be marked as external.

BREAKING CHANGE: x

Related issue (if exists):

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: b0c7940

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farmfe/js-plugin-electron Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wre232114
Copy link
Member

Thanks!

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #2012 will create unknown performance changes

Comparing JellyBrick:patch-1 (b0c7940) with main (a785d6f)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

Copy link
Contributor

@caoxiemeihao caoxiemeihao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shulandmimi shulandmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execute npx changeset in the project root directory and select @farmfe/js-plugin-electron to generate a changeset file, we upgrade the version number according to this file (and this change is considered to be a patch

@fu050409 fu050409 requested a review from shulandmimi December 23, 2024 15:57
@ErKeLost
Copy link
Member

Looks like electron example ci failed

@wre232114 wre232114 enabled auto-merge (squash) December 24, 2024 06:24
@wre232114 wre232114 merged commit 3d5506a into farm-fe:main Dec 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants