-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js-plugin-electron): dependencies unintentionally marked as external #2012
Conversation
'electron' -> '^electron$'
🦋 Changeset detectedLatest commit: b0c7940 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks! |
CodSpeed Performance ReportMerging #2012 will create unknown performance changesComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Execute npx changeset
in the project root directory and select @farmfe/js-plugin-electron
to generate a changeset file, we upgrade the version number according to this file (and this change is considered to be a patch
Looks like electron example ci failed |
Description: fixed an issue where dependencies were unintentionally marked as
external
farm/js-plugins/electron/src/index.ts
Line 117 in 7481a23
electron-*
that matched theelectron
(regex), to be marked asexternal
.BREAKING CHANGE: x
Related issue (if exists):