Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some bugs #1991

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix: some bugs #1991

merged 3 commits into from
Dec 12, 2024

Conversation

ErKeLost
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: c36506a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "farm-docs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ErKeLost ErKeLost merged commit 05324c1 into farm-fe:v2-dev Dec 12, 2024
39 checks passed
@@ -128,6 +128,7 @@ export class Server extends httpServer {
*/
constructor(readonly inlineConfig: FarmCliOptions & UserConfig) {
super();
this.logger = new Logger();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not quite sure what this line of code does, it looks like we're correctly creating a logger when we call createServer anyway, is it really necessary here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call to resolveConfig is made after the server instance, which will cause if an error occurs, the logger is null.

const server = new Server(inlineConfig)
// not has logger

server.createServer()

// has logger

Maybe we can find other ways to solve this problem. createServer is mainly for restart Server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants