fix: check different node environment (#1947)

farm-fe · Nov 20, 2024 · 3085d64 · 3085d64
1 parent 3770a12
commit 3085d64
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/.changeset/slow-humans-worry.md b/.changeset/slow-humans-worry.md
@@ -0,0 +1,5 @@
+---
+"@farmfe/core": patch
+---
+
+judgement node environment with check input value
diff --git a/packages/core/src/config/index.ts b/packages/core/src/config/index.ts
@@ -26,6 +26,7 @@ import {
   green,
   isArray,
   isEmptyObject,
+  isNodeEnv,
   isObject,
   isWindows,
   normalizeBasePath,
@@ -669,7 +670,8 @@ const formatFromExt: Record<string, Format> = {
   cjs: 'cjs',
   mjs: 'esm',
   cts: 'cjs',
-  mts: 'esm'
+  mts: 'esm',
+  js: 'esm'
 };
 
 const formatToExt: Record<Format, string> = {
@@ -948,7 +950,7 @@ export async function loadConfigFile(
 function checkCompilationInputValue(userConfig: UserConfig, logger: Logger) {
   const { compilation } = userConfig;
   const targetEnv = compilation?.output?.targetEnv;
-  const isTargetNode = targetEnv === 'node';
+  const isTargetNode = isNodeEnv(targetEnv);
   const defaultHtmlPath = './index.html';
   let inputIndexConfig: { index?: string } = { index: '' };
   let errorMessage = '';

diff --git a/packages/core/src/utils/share.ts b/packages/core/src/utils/share.ts
@@ -4,7 +4,7 @@ import os from 'node:os';
 import path, { dirname } from 'node:path';
 import readline from 'node:readline';
 import { fileURLToPath } from 'node:url';
-import { Config } from '../types/binding.js';
+import { Config, OutputConfig } from '../types/binding.js';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore import packageJson from '../../package.json';
 
@@ -177,3 +177,7 @@ export function tryStatSync(file: string): fs.Stats | undefined {
     return fs.statSync(file, { throwIfNoEntry: false });
   } catch {}
 }
+
+export function isNodeEnv(env: OutputConfig['targetEnv']): boolean {
+  return /^(node|library)(?!-browser)/.test(env);
+}