Skip to content

Commit

Permalink
Update facebook screenshot lib to 0.8.0
Browse files Browse the repository at this point in the history
- LEARNER-5799
- Comment Removed attributes from the screentshots gradle file.
- Move the screenshots png's to the new directory named "API_21_NO_GP_XHDPI_768x1280_armeabi-v7a_"
- Move extra png's(having issue to complete screenshoot test) to the new directory named "discovery_screenshots".
- Move the DiscoveryLaunchScreenshotTests(having issue to perform screenshot test) to the root directory.
  • Loading branch information
farhan-arshad-dev committed Oct 15, 2018
1 parent 1263551 commit fdb91a2
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 10 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ test:
validate: quality test

e2e :
@./gradlew verifyMode screenshotTests -PdisablePreDex
@./gradlew verifyProdDebuggableAndroidTestScreenshotTest -PdisablePreDex

artifacts:
@./gradlew copyLintBuildArtifacts
@./gradlew copyUnitTestBuildArtifacts
@./gradlew recordMode pullScreenshots -PdisablePreDex
@./gradlew pullProdDebuggableAndroidTestScreenshots -PdisablePreDex
16 changes: 9 additions & 7 deletions OpenEdXMobile/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ buildscript {
//Included for NewRelic
classpath "com.newrelic.agent.android:agent-gradle-plugin:5.4.1"

classpath 'com.facebook.testing.screenshot:plugin:0.6.0'
classpath 'com.facebook.testing.screenshot:plugin:0.8.0'
classpath 'com.google.gms:google-services:4.0.1'
}
}
Expand Down Expand Up @@ -281,10 +281,12 @@ android {
// test configuration
testApplicationId 'org.edx.mobile.test'

if (project.gradle.startParameter.taskNames.contains("screenshotTests")) {
Map<String, String> map = new HashMap<String, String>();
map.put("package", "org.edx.mobile.test.screenshot");
setTestInstrumentationRunnerArguments map
for(commands in project.gradle.startParameter.taskNames) {
if (commands .contains("ScreenshotTest") ) {
Map<String, String> map = new HashMap<String, String>();
map.put("package", "org.edx.mobile.test.screenshot");
setTestInstrumentationRunnerArguments map
}
}

testInstrumentationRunner "org.edx.mobile.test.EdXTestRunner"
Expand Down Expand Up @@ -475,6 +477,6 @@ android.applicationVariants.all { variant ->
}

screenshots {
testApkTarget = 'packageProdDebuggableAndroidTest'
connectedAndroidTestTarget = 'connectedProdDebuggableAndroidTest'
// testApkTarget = 'packageProdDebuggableAndroidTest'
// connectedAndroidTestTarget = 'connectedProdDebuggableAndroidTest'
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.edx.mobile.test.screenshot.test;
package org.edx.mobile.test;

import org.edx.mobile.view.DiscoveryLaunchActivity;
import org.edx.mobile.view.DiscoveryLaunchPresenter;
Expand Down

0 comments on commit fdb91a2

Please sign in to comment.