Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker Build Functionality #1

Merged
merged 4 commits into from
Dec 22, 2019
Merged

Conversation

mhanberry1
Copy link

This can now be build using a docker container.

@fangohr
Copy link
Owner

fangohr commented Dec 16, 2019

Very nice, thank you. I like the comments in the new scripts, thank you.

Adding the rest2www tar file is a good idea I think.

The tarball and other binaries are currently hosted on mag.soton.ac.uk and we need to migrate them to a new place (which?).

I have added one comment to add that this repo does not contain the documentation, but just the high level webpage overview. (Documentaino is in http://github.com/fangohr/nmag-doc, and [somehow] rendered to http://nmag.readthedocs.io.

Can you update the documentation links to point to http://nmag.readthedocs.io?

Regarding making this compile in a container, this looks good to me.

@mhanberry1
Copy link
Author

mhanberry1 commented Dec 18, 2019

I've changed the links so that they point to http://nmag.readthedocs.io, and I've removed the links for the manual in "multiple html files" because they no longer makes sense.

@fangohr
Copy link
Owner

fangohr commented Dec 22, 2019

Looks good to me, thanks.

@fangohr fangohr merged commit d252df4 into fangohr:master Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants