-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#29 added cookiesettings section to authenticationSettings #31
#29 added cookiesettings section to authenticationSettings #31
Conversation
…tings, if cookiesettings is defined set the preferences in gatewayAuthentication
Would you mind to initialize the the gateway auth settings with a default instance of your cookie settings and initialize all properties of you cookie settings with true. I think this way we have highest possible security settings by default. |
@fancyDevelopment ok, good call! |
…most secure instance
@fancyDevelopment I pushed some changes to initialize a default CookieSettings instance with the most secure settings, furthermore settings can be overridden one by one, so we don't lose our security if for instance someone only sets SameSiteStrict to false, the others will remain true. |
@fancyDevelopment I managed to get a commit in with my own account (via the Github editor in the browser). so commit 83fb671 should reference my personal account and hopefully add me as a contributor, i'll make sure to make changes with my personal account in the future :) |
#29 added cookiesettings section to authenticationSettings, if cookiesettings is defined set the preferences in gatewayAuthentication