Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migration script for LDAP sync #93

Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat: Migration script for LDAP sync #93

merged 2 commits into from
Dec 10, 2024

Conversation

jannden
Copy link
Contributor

@jannden jannden commented Nov 14, 2024

Closes #88

@jannden jannden requested a review from a team as a code owner November 14, 2024 13:04
@jannden jannden self-assigned this Nov 14, 2024
@tlater-famedly tlater-famedly force-pushed the tlater/remove-cache branch 4 times, most recently from 15dca27 to 3ebe290 Compare November 14, 2024 14:15
@jannden jannden force-pushed the jannden/migration-hex branch from 4866de8 to 4b75b03 Compare December 4, 2024 14:37
src/bin/migrate.rs Outdated Show resolved Hide resolved
src/bin/migrate.rs Outdated Show resolved Hide resolved
src/bin/migrate.rs Outdated Show resolved Hide resolved
src/bin/migrate.rs Outdated Show resolved Hide resolved
src/bin/migrate.rs Outdated Show resolved Hide resolved
src/bin/migrate.rs Outdated Show resolved Hide resolved
src/bin/migrate.rs Outdated Show resolved Hide resolved
tests/e2e.rs Show resolved Hide resolved
tests/e2e.rs Show resolved Hide resolved
@tlater-famedly tlater-famedly force-pushed the tlater/remove-cache branch 7 times, most recently from c00730f to 519ddba Compare December 5, 2024 08:08
Base automatically changed from tlater/remove-cache to main December 5, 2024 09:02
src/bin/migrate.rs Outdated Show resolved Hide resolved
src/bin/migrate.rs Outdated Show resolved Hide resolved
src/zitadel.rs Outdated Show resolved Hide resolved
@jannden jannden force-pushed the jannden/migration-hex branch from 4b75b03 to d65d97e Compare December 6, 2024 14:32
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 95.87021% with 14 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (519ddba) to head (fa8ffcb).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/user.rs 84.05% 11 Missing ⚠️
src/bin/migrate.rs 98.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   92.01%   93.26%   +1.25%     
==========================================
  Files           8        9       +1     
  Lines        1277     1604     +327     
==========================================
+ Hits         1175     1496     +321     
- Misses        102      108       +6     
Files with missing lines Coverage Δ
src/lib.rs 86.40% <100.00%> (ø)
src/zitadel.rs 96.63% <100.00%> (+4.08%) ⬆️
src/bin/migrate.rs 98.72% <98.72%> (ø)
src/user.rs 91.66% <84.05%> (-8.34%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 519ddba...fa8ffcb. Read the comment docs.

Copy link
Contributor

@skomski skomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions that I encountered.

src/zitadel.rs Outdated Show resolved Hide resolved
src/bin/migrate.rs Outdated Show resolved Hide resolved
src/bin/migrate.rs Show resolved Hide resolved
@jannden jannden merged commit fa8ffcb into main Dec 10, 2024
5 checks passed
@jannden jannden deleted the jannden/migration-hex branch December 10, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration executable for encoding old IDs
4 participants