Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required changes for famedly.de #82

Merged
merged 2 commits into from
Nov 5, 2024
Merged

required changes for famedly.de #82

merged 2 commits into from
Nov 5, 2024

Conversation

lukaslihotzki-f
Copy link
Contributor

@lukaslihotzki-f lukaslihotzki-f commented Nov 4, 2024

famedly.de uses plain MXIDs, so localpart needs to be set to the external user id on this org. This behavior is enabled with the PlainLocalpart feature flag.

Also, famedly.de uses openldap instead of Active Directory, which encodes the status differently. Instead of an integer encoding flags with bits, the strings "TRUE" and "FALSE" are used. This is specified by configuring the disable bitmask 0.

@lukaslihotzki-f lukaslihotzki-f requested a review from a team as a code owner November 4, 2024 11:49
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.76%. Comparing base (629df56) to head (a787e25).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sources/ldap.rs 83.33% 7 Missing ⚠️
src/zitadel.rs 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   86.94%   86.76%   -0.19%     
==========================================
  Files           7        7              
  Lines        1310     1352      +42     
==========================================
+ Hits         1139     1173      +34     
- Misses        171      179       +8     
Files with missing lines Coverage Δ
src/config.rs 96.31% <100.00%> (+0.06%) ⬆️
src/sources/ldap.rs 95.68% <83.33%> (-0.24%) ⬇️
src/zitadel.rs 75.46% <46.15%> (-1.20%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123b271...a787e25. Read the comment docs.

@lukaslihotzki-f lukaslihotzki-f force-pushed the ll/famedly-de branch 2 times, most recently from ea442bb to 485c30d Compare November 4, 2024 13:31
src/sources/ldap.rs Outdated Show resolved Hide resolved
src/zitadel.rs Outdated Show resolved Hide resolved
@lukaslihotzki-f lukaslihotzki-f force-pushed the ll/famedly-de branch 2 times, most recently from b660179 to bebd9f2 Compare November 4, 2024 15:04
@tlater-famedly
Copy link
Contributor

We should override codecov here; It's basing its patch diff on the v2/cache-less branch, which got rid of a bunch of code, and is therefore much better tested.

tlater-famedly
tlater-famedly previously approved these changes Nov 4, 2024
src/sources/ldap.rs Outdated Show resolved Hide resolved
src/sources/ldap.rs Show resolved Hide resolved
@lukaslihotzki-f lukaslihotzki-f merged commit a787e25 into main Nov 5, 2024
4 of 5 checks passed
@lukaslihotzki-f lukaslihotzki-f deleted the ll/famedly-de branch November 5, 2024 10:28
@lukaslihotzki-f lukaslihotzki-f mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants