-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
required changes for famedly.de #82
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 86.94% 86.76% -0.19%
==========================================
Files 7 7
Lines 1310 1352 +42
==========================================
+ Hits 1139 1173 +34
- Misses 171 179 +8
Continue to review full report in Codecov by Sentry.
|
ea442bb
to
485c30d
Compare
b660179
to
bebd9f2
Compare
We should override codecov here; It's basing its patch diff on the v2/cache-less branch, which got rid of a bunch of code, and is therefore much better tested. |
bebd9f2
to
a67c9ad
Compare
a67c9ad
to
a787e25
Compare
famedly.de uses plain MXIDs, so localpart needs to be set to the external user id on this org. This behavior is enabled with the PlainLocalpart feature flag.
Also, famedly.de uses openldap instead of Active Directory, which encodes the status differently. Instead of an integer encoding flags with bits, the strings "TRUE" and "FALSE" are used. This is specified by configuring the disable bitmask 0.