-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore common UDP ports #260
base: main
Are you sure you want to change the base?
Conversation
443 (http3) and 88 (kerberos) are expected to see UDP traffic Signed-off-by: jackmtpt <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jackmtpt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @jackmtpt! It looks like this is your first PR to falcosecurity/rules 🎉 |
Thank you 🎉 , we will check on it soon! |
Rules files suggestionsfalco-incubating_rules.yamlComparing Patch changes:
|
Looks like the linting job failed for a bunch of files that weren't modified in this PR? |
Yes this is currently always failing as we have not yet reached a consensus wrt to the best linting approach. This CI check is also not required to pass atm. Re the changes -- I don't see problems with the changes as in many rules we are a bit more conservative. This rule is an "incubating" rule and highly environment specific wrt what is considered unexpected, so it's fair to expect adopters to adjust this rule for their environment anyways. @darryk10 could you help with the review? Thanks. [Some of the reviewers may still be on PTO and this review may be delayed]. |
cc @loresuso |
Hi, |
To be honest we probably would not bother whitelisting (port, app) pairs in these rules; it's too much duplication from network policies/firewall rules. |
443 (http3) and 88 (kerberos) are expected to see UDP traffic
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-incubating
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: