fix(libsinsp,test): remove undefined behavior in test event generation #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
poiana
added
kind/bug
|
/milestone 0.11.0 |
incertum
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Thanks @LucaGuerra also for sharing your debugging journey 😎
/approve
|
LGTM label has been added. Git tree hash: 8ffeba4dbdce13525512670d90b2de4d56476d85
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
No.
What this PR does / why we need it:
This PR fixes a fun bug in the libsinsp test suite that is simply an instance of this: https://stackoverflow.com/questions/727663/why-does-this-variadic-function-fail-on-4th-parameter-on-windows-x64 .
Essentially, passing an integer literal to a variadic function and expecting a 64 bit value is undefined behavior, as the integer literal is type
intand not the correct 64 bit size. We caught this on ARM64 after the 8th parameter due to that specific implementation and parameter passing via registers/stack but could happen anywhere.The fix is simply to either cast the integer or pass a variable, which is what happens in this PR. When I felt it right I added some descriptive variable names so tests can still be easy to read.
We will need another similar PR everywhere we call the event encoding function (I believe in the gVisor implementation).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Merging this PR unblocks this: #962 .
Does this PR introduce a user-facing change?: