Add const_expr_visitor, use it when compiling/cloning/stringing #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
In some cases, we want to ensure that a visitor does *not* change the ast. This includes cases where the ast pointer used by the visitor is read-only. To support these use cases, add a const_expr_visitor interface where all the visit() methods take a const argument. Also add variants of accept() that take const_expr_visitor arguments and call the const_expr_visitors visit() method. Compiling, cloning, and stringifying asts are all cases that should not change the underlying ast, so switch those to use const_expr_visitor instead of expr_visitor. A couple of compile private methods had to be changed to take const arguments. They already didn't modify those arguments, so it was a safe change. Signed-off-by: Mark Stemm <[email protected]>
mstemm
force-pushed
the
make-ast-arguments-const-when-possible
branch
from
29cedf0
to
16db068
Compare
|
I did also build falco with this branch and the changes didn't cause any problems. The falco build itself did fail, but I suspect that's because other libs changes (looks like removing |
jasondellaluce
approved these changes
Jan 20, 2023
|
LGTM label has been added. Git tree hash: a968d2ea9e5db8968bffd02c0518447c6b3f4e2a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mstemm
added a commit
that referenced
this pull request
Mar 27, 2023
Following on the changes in #837, add a const variant of base_expr_visitor. This allows definining subclasses that want to traverse an ast read-only without implementng all the methods. Signed-off-by: Mark Stemm <[email protected]>
poiana
pushed a commit
that referenced
this pull request
Mar 28, 2023
Following on the changes in #837, add a const variant of base_expr_visitor. This allows definining subclasses that want to traverse an ast read-only without implementng all the methods. Signed-off-by: Mark Stemm <[email protected]>
araujof
pushed a commit
to sysflow-telemetry/libs
that referenced
this pull request
Mar 30, 2023
Following on the changes in falcosecurity#837, add a const variant of base_expr_visitor. This allows definining subclasses that want to traverse an ast read-only without implementng all the methods. Signed-off-by: Mark Stemm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
In some cases, we want to ensure that a visitor does not change the ast. This includes cases where the ast pointer used by the visitor is read-only.
To support these use cases, add a const_expr_visitor interface where all the visit() methods take a const argument.
Also add variants of accept() that take const_expr_visitor arguments and call the const_expr_visitors visit() method.
Compiling, cloning, and stringifying asts are all cases that should not change the underlying ast, so switch those to use const_expr_visitor instead of expr_visitor.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: