Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sinsp-example): handle SCAP_FILTERED_EVENT #678

Conversation

deepskyblue86
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

/area tests

Does this PR require a change in the driver versions?

What this PR does / why we need it:
Adapt sinsp-example to #674 and restore its functionality

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
See #674

Does this PR introduce a user-facing change?:

NONE

@deepskyblue86
Copy link
Contributor Author

@Molter73 hopefully this would fix the e2e 🙂

@FedeDP
Copy link
Contributor

FedeDP commented Oct 21, 2022

Yay passing! Great job man!

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 21, 2022

LGTM label has been added.

Git tree hash: b88c878354ce688ed567cd3422177cddacfe9b4f

Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for this Angelo, I see two of the e2e tests already pass so I have no reason to believe the last one will fail. Sorry I didn't catch this before merging the CI change, but in fairness, I rebased the PR on Tuesday and by Thursday it was already broken 😞

@poiana
Copy link
Contributor

poiana commented Oct 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, FedeDP, Molter73

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Oct 21, 2022

We break at a ftl speed! 😆

@Molter73
Copy link
Contributor

Molter73 commented Oct 21, 2022

We break at a ftl speed! 😆

Hopefully not anymore 🤣

@poiana poiana merged commit c14dbca into falcosecurity:master Oct 21, 2022
@deepskyblue86 deepskyblue86 deleted the fix/sinsp-example-SCAP_FILTERED_EVENT branch October 21, 2022 08:40
@Andreagit97 Andreagit97 added this to the 0.10.0 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants