-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sinsp-example): handle SCAP_FILTERED_EVENT #678
fix(sinsp-example): handle SCAP_FILTERED_EVENT #678
Conversation
Signed-off-by: Angelo Puglisi <[email protected]>
@Molter73 hopefully this would fix the e2e 🙂 |
Yay passing! Great job man! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: b88c878354ce688ed567cd3422177cddacfe9b4f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for this Angelo, I see two of the e2e tests already pass so I have no reason to believe the last one will fail. Sorry I didn't catch this before merging the CI change, but in fairness, I rebased the PR on Tuesday and by Thursday it was already broken 😞
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepskyblue86, FedeDP, Molter73 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We break at a ftl speed! 😆 |
Hopefully not anymore 🤣 |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Adapt
sinsp-example
to #674 and restore its functionalityWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
See #674
Does this PR introduce a user-facing change?: