-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: fsconfig support #606
Conversation
/milestone 3.0.0+driver |
I also wonder if this event is (or should be) compatible with extraction fields such as: |
driver/modern_bpf/programs/tail_called/events/syscall_dispatched_events/fsconfig.bpf.c
Outdated
Show resolved
Hide resolved
@jasondellaluce |
So, to make it work with
TBH i don't think we really need it, because one can just use
that we won't have, as said before, until we gain support |
Note: i'd love to push for |
|
Signed-off-by: Andrea Terzolo <[email protected]>
Co-authored-by: Andrea Terzolo <[email protected]> Signed-off-by: Federico Di Pierro <[email protected]>
…le flags. Signed-off-by: Federico Di Pierro <[email protected]> Co-authored-by: Jason Dellaluce <[email protected]>
…enter` events. Signed-off-by: Federico Di Pierro <[email protected]>
3d14228
to
f0deb77
Compare
Signed-off-by: Federico Di Pierro <[email protected]>
f0deb77
to
8ce9fbe
Compare
LGTM label has been added. Git tree hash: 95f68d6de10c3c1df0474a81f28b33a0193e6f70
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Federico Di Pierro <[email protected]>
LGTM label has been added. Git tree hash: 72c1606334d100fe50ce89a973f3d12bcc99963f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap
/area tests
Does this PR require a change in the driver versions?
/version driver-SCHEMA-version-minor
That was already bumped since last release.
What this PR does / why we need it:
See #605
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
In both 3 drivers implementation, it was chosen to return empty params for user-provided pointers in case of failure, to avoid reading out of bounds data.
Moreover, we chose to split up 4th param in 2:
value_bytebuf
value_charbuf
because it has different meaning in different situation (see https://elixir.bootlin.com/linux/latest/source/fs/fsopen.c#L314).
There is no need for any userspace parser, because at the moment we haven't got support for filesystem related FD flags/informations.
Does this PR introduce a user-facing change?: