Show driver version on modinfo #54
Conversation
Currently, modinfo lacks the version information on sysdig module. This patch just adds that information. Signed-off-by: Guilherme G. Piccoli <[email protected]>
|
Welcome @guilhermepiccoli! It looks like this is your first PR to falcosecurity/libs 🎉 |
|
Hi @guilhermepiccoli. Thanks for your PR. I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
👍 from me, though I expect this will become the API version string once #71 moves forward. |
|
LGTM label has been added. Git tree hash: 6338b1f8bdbff27f979cee9fb4e9030b1cd26917
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guilhermepiccoli, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
poiana
added
approved
release-note
and removed
do-not-merge/release-note-label-needed
labels
* Make sinsp remove_inactive_threads() method public In the Sysdig agent's Secure_Light mode, the agent_diagnostic_metrics_sender functions as a lightweight version of the sinsp_analyzer, and needs similar access to the private method remove_inactive_threads(). This PR makes the method public.
* Make sinsp remove_inactive_threads() method public In the Sysdig agent's Secure_Light mode, the agent_diagnostic_metrics_sender functions as a lightweight version of the sinsp_analyzer, and needs similar access to the private method remove_inactive_threads(). This PR makes the method public.
* Make sinsp remove_inactive_threads() method public In the Sysdig agent's Secure_Light mode, the agent_diagnostic_metrics_sender functions as a lightweight version of the sinsp_analyzer, and needs similar access to the private method remove_inactive_threads(). This PR makes the method public.
* Make sinsp remove_inactive_threads() method public In the Sysdig agent's Secure_Light mode, the agent_diagnostic_metrics_sender functions as a lightweight version of the sinsp_analyzer, and needs similar access to the private method remove_inactive_threads(). This PR makes the method public.
* Make sinsp remove_inactive_threads() method public In the Sysdig agent's Secure_Light mode, the agent_diagnostic_metrics_sender functions as a lightweight version of the sinsp_analyzer, and needs similar access to the private method remove_inactive_threads(). This PR makes the method public.
* Make sinsp remove_inactive_threads() method public In the Sysdig agent's Secure_Light mode, the agent_diagnostic_metrics_sender functions as a lightweight version of the sinsp_analyzer, and needs similar access to the private method remove_inactive_threads(). This PR makes the method public.
Currently, modinfo lacks the version information on sysdig module.
This patch just adds that information.
Signed-off-by: Guilherme G. Piccoli [email protected]
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: