-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(cmake): updated c-ares to latest 1.33.1 version. #2034
Conversation
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2034 +/- ##
=======================================
Coverage 73.57% 73.57%
=======================================
Files 253 253
Lines 31860 31860
Branches 5640 5648 +8
=======================================
Hits 23442 23442
- Misses 8407 8417 +10
+ Partials 11 1 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/milestone TBD |
Signed-off-by: Federico Di Pierro <[email protected]>
/milestone 0.19.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Federico Di Pierro <[email protected]>
d886527
to
7a22db7
Compare
Signed-off-by: Federico Di Pierro <[email protected]>
7a22db7
to
87f03c0
Compare
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Also, now c-ares supports cmake, therefore make use of it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This should help resolving a build issue in falcosecurity/falco#3307.
While not fundamental for now, it is a nice to have.
Does this PR introduce a user-facing change?: