Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated protobuf version for s390x #134

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

dandotimujahid
Copy link

@dandotimujahid dandotimujahid commented Nov 17, 2021

Signed-off-by: Mujahid-Dandoti [email protected]

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:
Updated protobuf version from 3.5.0 to 3.17.3 in protobuf.cmake for s390x.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

build: updated protobuf version from 3.5.0 to 3.17.3 for s390x

Signed-off-by: Mujahid-Dandoti <[email protected]>
@poiana
Copy link
Contributor

poiana commented Nov 17, 2021

Welcome @dandotimujahid! It looks like this is your first PR to falcosecurity/libs 🎉

@poiana
Copy link
Contributor

poiana commented Nov 17, 2021

Hi @dandotimujahid. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Nov 18, 2021

/ok-to-test

@dandotimujahid
Copy link
Author

@gnosek could you please have a look on my PR.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also, tested on s390x (thanks to @terylt)

@poiana
Copy link
Contributor

poiana commented Dec 13, 2021

LGTM label has been added.

Git tree hash: d203fa58b14ebb1f099286425a1a8cf4b05c1bed

@leogr
Copy link
Member

leogr commented Dec 13, 2021

/approve

@poiana
Copy link
Contributor

poiana commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dandotimujahid, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b573c6e into falcosecurity:master Dec 15, 2021
@poiana poiana mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants