-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated protobuf version for s390x #134
Conversation
Signed-off-by: Mujahid-Dandoti <[email protected]>
Welcome @dandotimujahid! It looks like this is your first PR to falcosecurity/libs 🎉 |
Hi @dandotimujahid. Thanks for your PR. I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@gnosek could you please have a look on my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also, tested on s390x (thanks to @terylt)
LGTM label has been added. Git tree hash: d203fa58b14ebb1f099286425a1a8cf4b05c1bed
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dandotimujahid, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mujahid-Dandoti [email protected]
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Updated protobuf version from 3.5.0 to 3.17.3 in protobuf.cmake for s390x.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: