Fix link for libraries contibutions in README.md #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/documentation
|
Welcome @sachinkumarsingh092! It looks like this is your first PR to falcosecurity/libs 🎉 |
|
Hi @sachinkumarsingh092. Thanks for your PR. I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/release-note-none |
poiana
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Signed-off-by: Sachin Kumar Singh <[email protected]>
sachinkumarsingh092
force-pushed
the
patch-1
branch
from
a7fae23
to
f83e2c9
Compare
|
LGTM label has been added. Git tree hash: cb0707dfd78f1bee9b07c463b04b780d96d90a53
|
leogr
approved these changes
Nov 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, sachinkumarsingh092 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leogr
pushed a commit
to leogr/libs
that referenced
this pull request
Jan 5, 2023
* fix(container_engine): Only return on success or all retries failed Instead of always returning a result on the first attempt, only return results on success or when all retries have failed. This prevents spurious "container" events for incomplete results. This is especially important when both docker and cri are enabled, when both must be tried due to the cgroup pattern overlapping, but only one actually holds the container. Signed-off-by: Mark Stemm <[email protected]> * Log a warning when empty container infos are returned When empty container infos are passed up due to all attempts failing, log a warining. This will help highlight cases when the communication with the container runtime isn't working properly. Signed-off-by: Mark Stemm <[email protected]> * Add debug log to note when a lookup is async or sync The "async_xxx" refers to the code that performs the lookup (we used to have a separate "docker" engine, but it's been removed. To make it more clear about whether a lookup is synchronous or asynchronous, add a debug log. Signed-off-by: Mark Stemm <[email protected]> * Use bundled valijson for "regular" build valijson doesn't really have an ubuntu package, so it can't be preinstalled. Use the bundled valijson instead. * Add RE2 to container used for builds + tests This way it will be present when building with -DUSE_BUNDLED_DEPS=False Signed-off-by: Mark Stemm <[email protected]>
leogr
pushed a commit
to leogr/libs
that referenced
this pull request
Jan 5, 2023
This reverts commit 35d80de. It was probably causing some container runtime tests to fail.
leogr
pushed a commit
to leogr/libs
that referenced
this pull request
Jan 5, 2023
* Revert "Revert "Merge upstream pr 688 (falcosecurity#121)" (falcosecurity#122)" This reverts commit c8dbbf3. This adds the fix back. I'll test with an agent PR that updates/removes the tests. * Add the ability to "defer" an async lookup In some cases, the "server" code running run_impl might want to retry its work until later. The current version can't do that--once a key is dequeued using deque_next_key, it has to call store_value or lose the request. To make retries easier, add a method defer_lookup that pushes the key (and optional value) back onto the request queue with a configurable delay. After delay, the key will be pulled again with a call to dequeue_next_key(). Signed-off-by: Mark Stemm <[email protected]> * Use defer_lookup for container info retry instead of lookup_delayed When the container async lookup class wants to retry a lookup, the current version tries to use lookup_delayed to initiate a new request. It turns out that that doesn't work--if there's already an existing request in m_value_map, it assumes that the "server" doing run_impl will eventually return an answer, and doesn't add a request to the queue. The solution is to use the newly added lookup_delayed instead, which pushes the request back onto the queue with a short delay. Signed-off-by: Mark Stemm <[email protected]> * Use a separate max_wait_ms instead of re-using s_cri_timeout Now that timeouts are working, it may take several seconds for subsequent retries to complete. However, s_cri_timeout (typically 1 second) was being used for the max_wait_ms in cri_async_source. That would mean that a lookup would expire before the server side had retried the lookup. The solution is to use a separate 10 second max_wait_ms, which matches docker. Signed-off-by: Mark Stemm <[email protected]> Signed-off-by: Mark Stemm <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area proposals
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: