Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stats for Mattermost and add tests #99

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 15, 2020

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area outputs

What this PR does / why we need it:

  • fix the stats for Mattermost which was using for another receiver.
  • add some tests
  • format a bit

ps. I can add tests for the other if no one is against

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

@poiana
Copy link

poiana commented Nov 15, 2020

@cpanato: The label(s) area/outputs cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area outputs

What this PR does / why we need it:

  • fix the stats for Mattermost which was using for another receiver.
  • add some tests
  • format a bit

ps. I can add tests for the other if no one is against

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link

poiana commented Nov 15, 2020

Welcome @cpanato! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/L label Nov 15, 2020
outputs/mattermost.go Outdated Show resolved Hide resolved
@poiana
Copy link

poiana commented Nov 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Nov 15, 2020

LGTM label has been added.

Git tree hash: 1c7e7cdb716d1c1b897b140e9a91b068d469178f

@poiana poiana merged commit 0476e61 into falcosecurity:master Nov 15, 2020
@cpanato cpanato deleted the update_mattermost branch November 15, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants