refactor(init_client): merge InitClient and NewClient functions #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issif
changed the title
idrissneumann
force-pushed
the
refactor_init_client
branch
2 times, most recently
from
8b422f1
to
ee06084
Compare
idrissneumann
force-pushed
the
refactor_init_client
branch
7 times, most recently
from
c589e21
to
134f48a
Compare
idrissneumann
changed the title
idrissneumann
force-pushed
the
refactor_init_client
branch
5 times, most recently
from
44ae4bc
to
f9dab62
Compare
Signed-off-by: Idriss Neumann <[email protected]>
idrissneumann
force-pushed
the
refactor_init_client
branch
from
f9dab62
to
3ef51f3
Compare
idrissneumann
changed the title
poiana
added
do-not-merge/work-in-progress
and removed
do-not-merge/work-in-progress
labels
|
I think it's ready ^^ (cc @Issif ) Test with some outputs and docker ok |
Issif
approved these changes
Jan 25, 2024
|
LGTM label has been added. Git tree hash: 10c6ea59ffa8da833e8566e557727f518d898d12
|
Issif
approved these changes
Jan 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idrissneumann, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #763