Adds a SumoLogic Output #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlo Mencarelli <[email protected]>
|
Welcome @mencarellic! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
|
Thank you, I'll review it asap |
Issif
requested changes
Oct 10, 2023
Issif
requested changes
Oct 10, 2023
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: Carlo Mencarelli <[email protected]>
Issif
approved these changes
Oct 10, 2023
|
LGTM label has been added. Git tree hash: afd06f34cb696738cca1a50b8bea9abcace5782c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, mencarellic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR adds a SumoLogic output. Since we use SumoLogic and want to also send Falco data to Sumo for long term storage, I felt adding an output would be reasonable.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
I don't write Go daily (or really ever). However, I tested this against our SumoLogic account and everything seems to work, the finesse of someone experienced in the language may not be there.