Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global TLS config #588

Merged
merged 6 commits into from
Sep 3, 2023
Merged

Conversation

ibice
Copy link
Contributor

@ibice ibice commented Aug 9, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Following #574, we'd like to be able to specify a custom CA cert on the Kafka output. This PR adds a way to specify custom CAs as a global (i.e. common to all outputs) TLS option.

Which issue(s) this PR fixes:

Special notes for your reviewer:

For now, this feature just affects outputs that use the outputs.Client.Post() or Put() methods.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ibice

Thank you for this PR. However, before we look at it, we need you to sign off your commits. Could you fix that, please? 🙏

Also, I've noticed some tests are falling, PTAL.

@ibice
Copy link
Contributor Author

ibice commented Aug 10, 2023

Done @leogr, I signed off the commits and solved the linter warnings :)

@Issif Issif added this to the 2.29.0 milestone Aug 10, 2023
README.md Outdated Show resolved Hide resolved
config_example.yaml Outdated Show resolved Hide resolved
outputs/client.go Outdated Show resolved Hide resolved
ibice and others added 3 commits August 11, 2023 17:59
Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: Jorge Carpio <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: Jorge Carpio <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: Jorge Carpio <[email protected]>
Issif
Issif previously approved these changes Aug 11, 2023
@poiana poiana added the lgtm label Aug 11, 2023
@poiana
Copy link

poiana commented Aug 11, 2023

LGTM label has been added.

Git tree hash: f5b5787946db8edd63d74a98e0f439788398a4c9

@leogr
Copy link
Member

leogr commented Aug 21, 2023

Closing and reopening to trigger the CI
/close

@poiana poiana closed this Aug 21, 2023
@poiana
Copy link

poiana commented Aug 21, 2023

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Aug 21, 2023

/reopen

@poiana poiana reopened this Aug 21, 2023
@poiana
Copy link

poiana commented Aug 21, 2023

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leogr
leogr previously approved these changes Aug 21, 2023
@leogr
Copy link
Member

leogr commented Aug 21, 2023

Hey @ibice

the CI lint job (which is required) is failing with the following message:

Error: G402: TLS MinVersion too low. (gosec)

Could you fix it please? 🙏

cc @Issif

@ibice
Copy link
Contributor Author

ibice commented Aug 23, 2023

@leogr I'll fix it next week, I'm OOO right now

@leogr
Copy link
Member

leogr commented Aug 23, 2023

/hold

@Issif
Copy link
Member

Issif commented Aug 23, 2023

I can't review anyway before September, I'm off too

@ibice ibice dismissed stale reviews from leogr and Issif via 3774d3c August 29, 2023 13:59
@poiana poiana removed the lgtm label Aug 29, 2023
@poiana poiana requested review from Issif and leogr August 29, 2023 13:59
@poiana poiana removed the approved label Aug 29, 2023
@ibice
Copy link
Contributor Author

ibice commented Aug 29, 2023

@leogr I fixed the linter warning, sorry for the wait

@poiana poiana added the lgtm label Sep 2, 2023
@poiana
Copy link

poiana commented Sep 2, 2023

LGTM label has been added.

Git tree hash: 53c7741f77afd4f08d54eaaf415bf6cf3c4e5f7f

@poiana
Copy link

poiana commented Sep 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibice, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Sep 2, 2023
@Issif Issif merged commit a576ddf into falcosecurity:master Sep 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants