-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global TLS config #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ibice
Thank you for this PR. However, before we look at it, we need you to sign off your commits. Could you fix that, please? 🙏
Also, I've noticed some tests are falling, PTAL.
Signed-off-by: Jorge Carpio <[email protected]>
2599851
to
f9fbb19
Compare
Signed-off-by: Jorge Carpio <[email protected]>
Done @leogr, I signed off the commits and solved the linter warnings :) |
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: Jorge Carpio <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: Jorge Carpio <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: Jorge Carpio <[email protected]>
LGTM label has been added. Git tree hash: f5b5787946db8edd63d74a98e0f439788398a4c9
|
Closing and reopening to trigger the CI |
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@leogr I'll fix it next week, I'm OOO right now |
/hold |
I can't review anyway before September, I'm off too |
Signed-off-by: Jorge Carpio <[email protected]>
@leogr I fixed the linter warning, sorry for the wait |
LGTM label has been added. Git tree hash: 53c7741f77afd4f08d54eaaf415bf6cf3c4e5f7f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibice, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Following #574, we'd like to be able to specify a custom CA cert on the Kafka output. This PR adds a way to specify custom CAs as a global (i.e. common to all outputs) TLS option.
Which issue(s) this PR fixes:
Special notes for your reviewer:
For now, this feature just affects outputs that use the outputs.Client.Post() or Put() methods.