Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated typo in smtp logs. #56

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Conversation

cartyc
Copy link
Contributor

@cartyc cartyc commented Jan 22, 2020

Found what I think is a small typo in the smtp output. Changed the spelling from serveur to server.

@Issif
Copy link
Member

Issif commented Jan 23, 2020

You're right, Serveur is french word for Server, as you may guess.

I'll merge soon.

Thanks.

@Issif Issif added the kind/bug Something isn't working label Jan 23, 2020
@cartyc
Copy link
Contributor Author

cartyc commented Jan 23, 2020

Ahh that was my second guess. Is host the same in both Eng/French? If so would it make sense to rename it that.

@Issif Issif merged commit 566856b into falcosecurity:master Jan 28, 2020
@Issif
Copy link
Member

Issif commented Jan 28, 2020

@cartyc Host is Hôte in French. What occurencies do you want to change? I merged you PR anyway.

@cartyc
Copy link
Contributor Author

cartyc commented Jan 28, 2020

@Issif I hadn't looked around to find any more but that's something I can do to help make things consistent. I should have asked this before but is having bilingual output something you would be looking for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants