-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introducing telegram output #431
Conversation
Signed-off-by: zufardhiyaulhaq <[email protected]>
Welcome @zufardhiyaulhaq! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing PR, only 1 small thing to add
Signed-off-by: zufardhiyaulhaq <[email protected]>
done @Issif, please help check back |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, zufardhiyaulhaq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 8d2c6c8e725c5bf9956087d12e1e963d6d76ed66
|
@Issif what is the next step? I don't see the workflow running. can I start contributing to falcosidekick helm chart for this output? |
I don't know why it didn't start. I closed/reopened the PR, all tests started. |
For the helm chart update, we must wait for the release 2.28.0, we'll add the new settings at this moment. |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
tested on local