Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introducing telegram output #431

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

zufardhiyaulhaq
Copy link
Contributor

What type of PR is this?
/kind feature

Any specific area of the project related to this PR?
/area outputs

What this PR does / why we need it:

  • introducing telegram output
  • some company might use telegram for alerting system

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
tested on local
image
image
image

Signed-off-by: zufardhiyaulhaq <[email protected]>
@poiana
Copy link

poiana commented Mar 24, 2023

Welcome @zufardhiyaulhaq! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana requested review from cpanato and leogr March 24, 2023 17:57
@poiana poiana added the size/L label Mar 24, 2023
@Issif Issif self-assigned this Mar 24, 2023
@Issif Issif added this to the 2.28.0 milestone Mar 24, 2023
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing PR, only 1 small thing to add

Signed-off-by: zufardhiyaulhaq <[email protected]>
@zufardhiyaulhaq
Copy link
Contributor Author

done @Issif, please help check back
image

@zufardhiyaulhaq zufardhiyaulhaq requested review from Issif and removed request for leogr and cpanato March 25, 2023 05:19
@poiana poiana added the lgtm label Mar 25, 2023
@poiana
Copy link

poiana commented Mar 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, zufardhiyaulhaq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Mar 25, 2023

LGTM label has been added.

Git tree hash: 8d2c6c8e725c5bf9956087d12e1e963d6d76ed66

@zufardhiyaulhaq
Copy link
Contributor Author

@Issif what is the next step? I don't see the workflow running.

can I start contributing to falcosidekick helm chart for this output?

@Issif Issif closed this Mar 25, 2023
@Issif Issif reopened this Mar 25, 2023
@Issif
Copy link
Member

Issif commented Mar 25, 2023

@Issif what is the next step? I don't see the workflow running.

can I start contributing to falcosidekick helm chart for this output?

I don't know why it didn't start. I closed/reopened the PR, all tests started.

@Issif
Copy link
Member

Issif commented Mar 25, 2023

@Issif what is the next step? I don't see the workflow running.

can I start contributing to falcosidekick helm chart for this output?

For the helm chart update, we must wait for the release 2.28.0, we'll add the new settings at this moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants