Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redis output #396

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Add Redis output #396

merged 1 commit into from
Mar 1, 2023

Conversation

pandyamarut
Copy link
Contributor

Signed-off-by: pandyamarut [email protected] (cloudDefense.ai)

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:
This introduces Redis output

@poiana
Copy link

poiana commented Feb 16, 2023

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana requested review from cpanato and leogr February 16, 2023 20:39
@poiana poiana added the size/L label Feb 16, 2023
@poiana
Copy link

poiana commented Feb 16, 2023

@anshubansal2000: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issif
Issif requested changes Feb 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
outputs/redis.go Show resolved Hide resolved
outputs/redis.go Outdated Show resolved Hide resolved
outputs/redis.go Outdated Show resolved Hide resolved
outputs/redis.go Outdated Show resolved Hide resolved
outputs/redis.go Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pandyamarut pandyamarut requested review from Issif and removed request for leogr and cpanato February 21, 2023 21:44
Issif
Issif requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You linter changed a lot of things in the README, can you revert them please, it creates a flood in that PR and a drift with config_example.yaml which is supposed to be updated too with the new Redis section. Thanks

outputs/redis.go Show resolved Hide resolved
outputs/redis.go Outdated Show resolved Hide resolved
outputs/redis.go Outdated Show resolved Hide resolved
outputs/redis.go Outdated Show resolved Hide resolved
@poiana poiana added size/L and removed size/XL labels Feb 27, 2023
@Issif Issif added this to the 2.28.0 milestone Feb 27, 2023
Issif
Issif requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the config_example.yaml too, please

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
outputs/redis.go Outdated Show resolved Hide resolved
Issif
Issif approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats 🎉

@poiana poiana added the lgtm label Feb 28, 2023
@poiana
Copy link

poiana commented Feb 28, 2023

LGTM label has been added.

Git tree hash: 0b56a734ac35813b7d79198aa8cfa514becc26d1

@Issif
Copy link
Member

Issif commented Feb 28, 2023

/lgtm
/approve

@Issif
Copy link
Member

Issif commented Feb 28, 2023

/unhold
/lgtm
/approve

@Issif Issif closed this Feb 28, 2023
@Issif Issif reopened this Feb 28, 2023
Issif
Issif previously approved these changes Feb 28, 2023
View reviewed changes
@pandyamarut
Add redis output
3427272 
Signed-off-by: pandyamarut <[email protected]>

extra space remove

Signed-off-by: pandyamarut <[email protected]>

fixes lint issues

Signed-off-by: pandyamarut <[email protected]>

fix output file lint issue

Signed-off-by: pandyamarut <[email protected]>

add another storage type and fix err tests

Signed-off-by: pandyamarut <[email protected]>

rebase with master

Signed-off-by: Marut Pandya <[email protected]>

adds configurable key value

Signed-off-by: pandyamarut <[email protected]>

edit config_example.yaml

Signed-off-by: pandyamarut <[email protected]>

Add redis output

Signed-off-by: pandyamarut <[email protected]>

add another storage type and fix err tests

Signed-off-by: pandyamarut <[email protected]>

adds configurable key value

Signed-off-by: pandyamarut <[email protected]>

edit config_example.yaml

Signed-off-by: pandyamarut <[email protected]>
@pandyamarut pandyamarut requested a review from Issif March 1, 2023 16:54
@poiana
Copy link

poiana commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, pandyamarut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fa2313e into falcosecurity:master Mar 1, 2023
@pandyamarut pandyamarut mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Issif Issif Issif approved these changes

@anshubansal2000 anshubansal2000 anshubansal2000 left review comments

Assignees

@Issif Issif

Labels
approved area/outputs dco-signoff: yes lgtm needs-kind size/L
Projects
Falcosidekick 2.x
Status: Done
Milestone
2.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pandyamarut @poiana @Issif @anshubansal2000