feat(SASL-Auth): Now SMTP output may use any SASL Auth mechanisms #341
Conversation
poiana
added
kind/documentation
dco-signoff: yes
kind/feature
|
Welcome @Lowaiz! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
|
I avoid to create breaking changes as much as possible, can you flat the config like you proposed please. I'll review in details right after. |
Done |
|
/reopen |
|
@Issif: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ne, Plain, OAuth-Bearer, External or Anonymous. Default to Plain. Updates: - Fixing the SMTP Format by adding the 'From' header Signed-off-by: Lyonel Martinez <[email protected]>
|
LGTM label has been added. Git tree hash: 9985cff66ec7db8a268e1f26f7410c03a70dd9d3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, Lowaiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In prevision of sidekick version bump. falcosecurity/falcosidekick#341 Signed-off-by: Lyonel Martinez <[email protected]>
feat(alertmanager-extra-fields): Updates values and secrets for AlertManager extra labels and annotations. In prevision of sidekick version bump. falcosecurity/falcosidekick#341 falcosecurity/falcosidekick#347 Signed-off-by: Lyonel Martinez <[email protected]>
feat(alertmanager-extra-fields): Updates values and secrets for AlertManager extra labels and annotations. In prevision of sidekick version bump. falcosecurity/falcosidekick#341 falcosecurity/falcosidekick#347 Signed-off-by: Lyonel Martinez <[email protected]>
Signed-off-by: Lyonel Martinez [email protected]
What type of PR is this?
/kind documentation
/kind feature
Any specific area of the project related to this PR?
/area config
/area outputs
What this PR does / why we need it:
SMTP output may now use any SASL Auth mechanisms from: Plain, OAuth-Bearer, External, Anonymous or may not use any SASL Authentication. Default to Plain.
Breaking change:- The configuration for SMTP's User/Password is now in the yaml sub-object 'auth' of the SMTP configurationWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Need some feedbacks on:- I moved the User/password infos in the 'auth' sub-object, but if we want to avoid breaking changes, I can change the config to flatten it. WDYT ?